]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Run virDomainInputDefPostParse() only for VIR_DOMAIN_DEVICE_INPUT
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 26 May 2023 14:15:56 +0000 (16:15 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 26 May 2023 14:28:54 +0000 (16:28 +0200)
Due to missed break; statement the virDomainInputDefPostParse()
is called not only for VIR_DOMAIN_DEVICE_INPUT but also
VIR_DOMAIN_DEVICE_LEASE and VIR_DOMAIN_DEVICE_NET, which can lead
to all sort of unpredictable results.

Fixes: c4bc4d3b82fbe22e03c986ca896090f481df5c10
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_postparse.c

index 7ef478e3e1745c3422f4c42f1207889bd80dbf17..c6695b460d9dfcb2d5159fcdf92570b55437ccc9 100644 (file)
@@ -725,12 +725,13 @@ virDomainDeviceDefPostParseCommon(virDomainDeviceDef *dev,
         ret = virDomainFSDefPostParse(dev->data.fs);
         break;
 
-    case VIR_DOMAIN_DEVICE_LEASE:
-    case VIR_DOMAIN_DEVICE_NET:
     case VIR_DOMAIN_DEVICE_INPUT:
         virDomainInputDefPostParse(dev->data.input, def);
         ret = 0;
         break;
+
+    case VIR_DOMAIN_DEVICE_LEASE:
+    case VIR_DOMAIN_DEVICE_NET:
     case VIR_DOMAIN_DEVICE_SOUND:
     case VIR_DOMAIN_DEVICE_WATCHDOG:
     case VIR_DOMAIN_DEVICE_GRAPHICS: