]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
pci: Deduplicate get_class_desc()
authorMarkus Armbruster <armbru@redhat.com>
Thu, 1 Dec 2022 12:11:26 +0000 (13:11 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 19 Dec 2022 15:21:56 +0000 (16:21 +0100)
pcibus_dev_print() contains a copy of get_class_desc().  Call the
function instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221201121133.3813857-7-armbru@redhat.com>

hw/pci/pci.c

index 7310a82cee78fce7b16245c94e664c5ca85db2a7..41718aaf60329054e3457dd8c9ce4dbf715ed93e 100644 (file)
@@ -2409,15 +2409,12 @@ uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id)
 static void pcibus_dev_print(Monitor *mon, DeviceState *dev, int indent)
 {
     PCIDevice *d = (PCIDevice *)dev;
-    const pci_class_desc *desc;
+    int class = pci_get_word(d->config + PCI_CLASS_DEVICE);
+    const pci_class_desc *desc = get_class_desc(class);
     char ctxt[64];
     PCIIORegion *r;
-    int i, class;
+    int i;
 
-    class = pci_get_word(d->config + PCI_CLASS_DEVICE);
-    desc = pci_class_descriptions;
-    while (desc->desc && class != desc->class)
-        desc++;
     if (desc->desc) {
         snprintf(ctxt, sizeof(ctxt), "%s", desc->desc);
     } else {