]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainDiskDef: Change type of geometry.trans to virDomainDiskGeometryTrans
authorTim Wiederhake <twiederh@redhat.com>
Tue, 18 May 2021 15:04:45 +0000 (17:04 +0200)
committerLaine Stump <laine@redhat.com>
Tue, 18 May 2021 16:27:12 +0000 (12:27 -0400)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/conf/domain_conf.c
src/conf/domain_conf.h

index 86680e0cdbe3aa7e2dedb134ce3837e5b70f7dc7..f55117e849ef50af0fc5a290f5b0dcac1d73ccce 100644 (file)
@@ -8845,13 +8845,14 @@ virDomainDiskDefGeometryParse(virDomainDiskDef *def,
     }
 
     if ((tmp = virXMLPropString(cur, "trans"))) {
-        def->geometry.trans = virDomainDiskGeometryTransTypeFromString(tmp);
-        if (def->geometry.trans <= 0) {
+        int value;
+        if ((value = virDomainDiskGeometryTransTypeFromString(tmp)) <= 0) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("invalid translation value '%s'"),
                            tmp);
             return -1;
         }
+        def->geometry.trans = value;
     }
 
     return 0;
index 41e570765e7e964ebc2fbd349508f851398f67ee..cf8481f1f64d4a5bb36f1a916e8ab0263ca82689 100644 (file)
@@ -549,7 +549,7 @@ struct _virDomainDiskDef {
         unsigned int cylinders;
         unsigned int heads;
         unsigned int sectors;
-        int trans; /* enum virDomainDiskGeometryTrans */
+        virDomainDiskGeometryTrans trans;
     } geometry;
 
     struct {