QEmu config error handling fixes

* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
  crashes when reading the config file
Daniel

diff --git a/ChangeLog b/ChangeLog
index 45536d41d382107ab3bfb6411f04326ff020f63f..74ebae576128c3a191bf6a215bc8ab9d916c269d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Feb  6 17:22:34 CET 2008 Daniel Veillard <veillard@redhat.com>
+
+       * src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid 
+         crashes when reading the config file
+
 Tue Feb  3 20:26:53 CET 2008  Jim Meyering  <meyering@redhat.com>
 
        Fix new "make distcheck" failures.

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index fe9eda906c50ebb5635969525a4a4a802e4438ee..39cfdc1ebc19f271a9c88b6903bc1212d6eb3bca 100644 (file)
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -1193,6 +1193,8 @@ static struct qemud_vm_def *qemudParseXML(virConnectPtr conn,
             } else if (!strcmp((char *)prop, "network")) {
                 def->os.bootDevs[def->os.nBootDevs++] = QEMUD_BOOT_NET;
             } else {
+               qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
+                                "unknown boot dev \'%s\'", (char*)prop);
                 goto error;
             }
             xmlFree(prop);
@@ -2523,7 +2525,8 @@ qemudLoadConfig(struct qemud_driver *driver,
     if (!(def = qemudParseVMDef(NULL, driver, xml, file))) {
         virErrorPtr err = virGetLastError();
         qemudLog(QEMUD_WARN, "Error parsing QEMU guest config '%s' : %s",
-                 path, err->message);
+                 path, err ? err->message :
+                            "BUG: unknown error - please report it\n");
         return NULL;
     }