diff: fix memory leak when appending a "too complex" diff entry

Found by Coverity Scan.

diff --git a/src/diff.c b/src/diff.c
index e076118e8401ef944df06320d5411655b4839410..40cda64232a478511f366f6ce8b3ff1ead79adaa 100644 (file)
--- a/src/diff.c
+++ b/src/diff.c
@@ -76,14 +76,15 @@ static int hwloc_append_diff_obj_attr_string(hwloc_obj_t obj,
                                             hwloc_topology_diff_t *lastdiffp)
 {
        hwloc_topology_diff_t newdiff;
-       newdiff = malloc(sizeof(*newdiff));
-       if (!newdiff)
-               return -1;
 
        if (obj->type == HWLOC_OBJ_MISC)
                /* TODO: add a custom level/depth for Misc */
                return hwloc_append_diff_too_complex(obj, firstdiffp, lastdiffp);
 
+       newdiff = malloc(sizeof(*newdiff));
+       if (!newdiff)
+               return -1;
+
        newdiff->obj_attr.type = HWLOC_TOPOLOGY_DIFF_OBJ_ATTR;
        newdiff->obj_attr.obj_depth = obj->depth;
        newdiff->obj_attr.obj_index = obj->logical_index;
@@ -104,14 +105,15 @@ static int hwloc_append_diff_obj_attr_uint64(hwloc_obj_t obj,
                                             hwloc_topology_diff_t *lastdiffp)
 {
        hwloc_topology_diff_t newdiff;
-       newdiff = malloc(sizeof(*newdiff));
-       if (!newdiff)
-               return -1;
 
        if (obj->type == HWLOC_OBJ_MISC)
                /* TODO: add a custom level/depth for Misc */
                return hwloc_append_diff_too_complex(obj, firstdiffp, lastdiffp);
 
+       newdiff = malloc(sizeof(*newdiff));
+       if (!newdiff)
+               return -1;
+
        newdiff->obj_attr.type = HWLOC_TOPOLOGY_DIFF_OBJ_ATTR;
        newdiff->obj_attr.obj_depth = obj->depth;
        newdiff->obj_attr.obj_index = obj->logical_index;