]> xenbits.xensource.com Git - people/dwmw2/xen.git/commitdiff
public: misra rule 20.7 fix on memory.h
authorLuca Fancellu <luca.fancellu@arm.com>
Thu, 22 Dec 2022 09:04:34 +0000 (10:04 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 22 Dec 2022 09:04:34 +0000 (10:04 +0100)
Cppcheck has found a violation of rule 20.7 for the macro
XENMEM_SHARING_OP_FIELD_MAKE_GREF, the argument "val" is used in an
expression, hence add parenthesis to the argument "val" to fix the
violation.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/include/public/memory.h

index 29cf5c823902c06fa9d55401dacfd2b60bbd9626..c5f0d31e235d7c2339fe784cb31b2c1cd3e962bb 100644 (file)
@@ -485,7 +485,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_access_op_t);
 #define XENMEM_SHARING_OP_FIELD_IS_GREF_FLAG   (xen_mk_ullong(1) << 62)
 
 #define XENMEM_SHARING_OP_FIELD_MAKE_GREF(field, val)  \
-    (field) = (XENMEM_SHARING_OP_FIELD_IS_GREF_FLAG | val)
+    (field) = (XENMEM_SHARING_OP_FIELD_IS_GREF_FLAG | (val))
 #define XENMEM_SHARING_OP_FIELD_IS_GREF(field)         \
     ((field) & XENMEM_SHARING_OP_FIELD_IS_GREF_FLAG)
 #define XENMEM_SHARING_OP_FIELD_GET_GREF(field)        \