ts-hosts-allocate-Executive: Make build failures not be host-sticky

Builds (jobs whose recipe contains `build') are not supposed to
contain host-specific tests.  We already don't care about varying
which host they run on, to hunt for host-specific bugs.

We should also not make build failures sticky to the host they last
failed on.

Fix this by defaulting $prevfail_bonus to 0 in that case, before the
week-long later default is applied.  This means that a build job
runvar would override the built-in default whether that's 7 days or 0.

Reported-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
index 82ef6285ea671118b6010066b1a40cfd18ba2155..54366a3300f4a2b7776a4f2e651aa790ecc0eaab 100755 (executable)
--- a/ts-hosts-allocate-Executive
+++ b/ts-hosts-allocate-Executive
@@ -624,6 +624,7 @@ sub hid_recurse ($$) {
     if ($jobinfo->{recipe} =~ m/build/) {
         $variation_age= 0;
        $duration_for_cost= $duration + $duration_rightaway_adjust;
+       $prevfail_bonus //= 0;
     }
 
     my $log_variation_age = log(1+$variation_age/86400);