]> xenbits.xensource.com Git - libvirt.git/commitdiff
build: Use $(LN_S) safely
authorAndrea Bolognani <abologna@redhat.com>
Wed, 20 Apr 2016 17:24:22 +0000 (19:24 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Thu, 21 Apr 2016 08:02:36 +0000 (10:02 +0200)
The autoconf documentation recommends to always use this
construct when creating symbolic links with $(LN_S) to avoid
unexpected behavior.

src/Makefile.am
tools/Makefile.am

index 016817768b1fa107c99377e190275095287dce2d..c639e37e3ee3b1907b986eb069eeb3bf0ce3daa1 100644 (file)
@@ -3078,8 +3078,8 @@ if WITH_NETWORK
            cp $(DESTDIR)$(confdir)/qemu/networks/default.xml.t \
              $(DESTDIR)$(confdir)/qemu/networks/default.xml && \
            rm $(DESTDIR)$(confdir)/qemu/networks/default.xml.t; }
-       $(LN_S) -f ../default.xml \
-           $(DESTDIR)$(confdir)/qemu/networks/autostart/default.xml
+       ( cd $(DESTDIR)$(confdir)/qemu/networks/autostart && \
+           $(LN_S) -f ../default.xml default.xml )
 endif WITH_NETWORK
 
 uninstall-local:: uninstall-init uninstall-systemd
index 7f2c0fcea9a7e1b8880714e46d65d448e9fc3e18..e963b9116fa9dea819d424af8d5e057d58871fbd 100644 (file)
@@ -423,8 +423,8 @@ LIBVIRT_NSS_SYMBOL_FILE = \
 NSS_SO_VER = 1
 
 install-exec-hook:
-       cd $(DESTDIR)$(libdir) && \
-         $(LN_S) -f libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER)
+       cd $(DESTDIR)$(libdir) && \
+         $(LN_S) -f libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) )
 
 uninstall-local:
        -rm -f $(DESTDIR)$(libdir)/nss_libvirt.so.$(NSS_SO_VER)