]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: Improve error reporting from qemuDomainManagedSaveRemove
authorPeter Krempa <pkrempa@redhat.com>
Tue, 11 Dec 2012 18:34:16 +0000 (19:34 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 12 Dec 2012 13:34:12 +0000 (14:34 +0100)
Report an error if unlink of the managedsave file fails.

src/qemu/qemu_driver.c

index 87c5b34258b00b5c5f02d8c0ca3331e624cf9242..1228f6ed817a1ed677ad0333305d1e17e601f695 100644 (file)
@@ -3337,8 +3337,15 @@ qemuDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags)
     if (!(name = qemuDomainManagedSavePath(driver, vm)))
         goto cleanup;
 
-    ret = unlink(name);
+    if (unlink(name) < 0) {
+        virReportSystemError(errno,
+                             _("Failed to remove managed save file '%s'"),
+                             name);
+        goto cleanup;
+    }
+
     vm->hasManagedSave = false;
+    ret = 0;
 
 cleanup:
     VIR_FREE(name);