bridge_driver: avoid double call to VIR_FREE

While not technically a double free (since VIR_FREE NULLs the
pointer), this is unnecessary extra code.

This crept in when the function was converted from virRun to virCommand.

The AUTHORS file has also been updated.

diff --git a/AUTHORS b/AUTHORS
index e065b185dc9cff1f047b8894c6385cab7eb6d1e6..b204bd6e095c791a87adf0636979e85ca46fa739 100644 (file)
--- a/AUTHORS
+++ b/AUTHORS
@@ -141,6 +141,7 @@ Patches have also been contributed by:
   MORITA Kazutaka      <morita.kazutaka@lab.ntt.co.jp>
   Josh Durgin          <joshd@hq.newdream.net>
   Roopa Prabhu         <roprabhu@cisco.com>
+  Paweł Krześniak      <pawel.krzesniak@gmail.com>
 
   [....send patches to get your name here....]
 

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index c3f32d782606fd0dbc39031bd954d5471d44301f..b0834ae2cbeb099601e602cb286b38edb4eda418 100644 (file)
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -557,7 +557,6 @@ dhcpStartDhcpDaemon(virNetworkObjPtr network)
 
     cmd = virCommandNew(DNSMASQ);
     if (networkBuildDnsmasqArgv(network, pidfile, cmd) < 0) {
-        VIR_FREE(pidfile);
         goto cleanup;
     }