tools/xenstored: Make gnttab interface mandatory

xenstored currently requires an libxc and evtchn interface, but leaves
the gnttab interface as optional.

gnttab is ubiquitous these days, and in practice mandatory in all cases
where xenstored isn't running as root in dom0 (due to the inability to
foreign map by MFN).

The toolstack has unconditionally set up grant details for many years
now, and longterm it would be good to phase out the use of libxc.  This
requires that xenstored map the store ring by grant map, rather than
foreign map.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>

diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c
index fa6655033afe6b1ad63bf3e7a054789a95a9aca9..463ebba6439e9a513e16095f71d4dcbf00519b57 100644 (file)
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -641,9 +641,9 @@ void domain_init(void)
 
        *xgt_handle = xengnttab_open(NULL, 0);
        if (*xgt_handle == NULL)
-               xprintf("WARNING: Failed to open connection to gnttab\n");
-       else
-               talloc_set_destructor(xgt_handle, close_xgt_handle);
+               barf_perror("Failed to open connection to gnttab");
+
+       talloc_set_destructor(xgt_handle, close_xgt_handle);
 
        xce_handle = xenevtchn_open(NULL, 0);