]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
pwm: atmel-hlcdc: Fix clock imbalance related to suspend support
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 26 Jan 2024 12:04:33 +0000 (13:04 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:20:33 +0000 (18:20 -0400)
[ Upstream commit e25ac87d3f831fed002c34aadddaf4ebb4ea45ec ]

The suspend callback disables the periph clock when the PWM is enabled
and resume reenables this clock if the PWM was disabled before. Judging
from the code comment it's suspend that is wrong here. Fix accordingly.

Fixes: f9bb9da7c09d ("pwm: atmel-hlcdc: Implement the suspend/resume hooks")
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Link: https://lore.kernel.org/r/b51ea92b0a45eff3dc83b08adefd43d930df996c.1706269232.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-atmel-hlcdc.c

index 4d0b859d0ac1373b1962e05e2eaf545c6d1f30c7..3e9c94a8d7f72fd6612ad633db2ca5fa185e90b2 100644 (file)
@@ -186,7 +186,7 @@ static int atmel_hlcdc_pwm_suspend(struct device *dev)
        struct atmel_hlcdc_pwm *atmel = dev_get_drvdata(dev);
 
        /* Keep the periph clock enabled if the PWM is still running. */
-       if (pwm_is_enabled(&atmel->chip.pwms[0]))
+       if (!pwm_is_enabled(&atmel->chip.pwms[0]))
                clk_disable_unprepare(atmel->hlcdc->periph_clk);
 
        return 0;