]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: command: Don't bother reporting errors in smbios formatters
authorPeter Krempa <pkrempa@redhat.com>
Mon, 10 Oct 2016 04:03:57 +0000 (06:03 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 14 Oct 2016 02:03:52 +0000 (04:03 +0200)
qemuBuildSmbiosBiosStr and qemuBuildSmbiosSystemStr return NULL if
there's nothing to format on the commandline. Reporting errors from
buffer creation doesn't make sense since it would be ignored.

src/qemu/qemu_command.c

index 96d2cc03af9889108b90bf5cf6478fba0dc8d17b..1d1d50824567cd38fe3ef5807120f6e73245df35 100644 (file)
@@ -5633,14 +5633,7 @@ qemuBuildSmbiosBiosStr(virSysinfoBIOSDefPtr def)
     if (def->release)
         virBufferAsprintf(&buf, ",release=%s", def->release);
 
-    if (virBufferCheckError(&buf) < 0)
-        goto error;
-
     return virBufferContentAndReset(&buf);
-
- error:
-    virBufferFreeAndReset(&buf);
-    return NULL;
 }
 
 
@@ -5681,14 +5674,7 @@ qemuBuildSmbiosSystemStr(virSysinfoSystemDefPtr def,
     if (def->family)
         virBufferAsprintf(&buf, ",family=%s", def->family);
 
-    if (virBufferCheckError(&buf) < 0)
-        goto error;
-
     return virBufferContentAndReset(&buf);
-
- error:
-    virBufferFreeAndReset(&buf);
-    return NULL;
 }