]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Resolve Coverity DEADCODE
authorJohn Ferlan <jferlan@redhat.com>
Wed, 1 Jul 2015 10:28:12 +0000 (06:28 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 1 Jul 2015 10:28:12 +0000 (06:28 -0400)
Commit id 'f967e7a6' didn't place the closing parentheses quite right
causing DEADCODE errors since the rc setting/comparison was wrong.

src/qemu/qemu_hotplug.c

index 391190dcdd17c91c917285a2fadd0c620a687a0c..79338cf61d17cfec48156520ca7c50c6e4c37746 100644 (file)
@@ -1586,7 +1586,7 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver,
     if (qemuAssignDeviceChrAlias(vmdef, chr, -1) < 0)
         goto cleanup;
 
-    if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr) < 0))
+    if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr)) < 0)
         goto cleanup;
     if (rc == 1)
         need_release = true;