]> xenbits.xensource.com Git - xen.git/commitdiff
libxl: remove the gate that only allows block or regular backing images
authorRoger Pau Monne <roger.pau@citrix.com>
Thu, 19 Jun 2014 16:32:47 +0000 (18:32 +0200)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 27 Jun 2014 13:13:23 +0000 (14:13 +0100)
On FreeBSD ZVOLs/disks/partitions are char devices, so libxl must
allow it's usage. This is already taken care in the OS-specific bits
of libxl by libxl__try_phy_backend, so remove the generic gate.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl_device.c

index 788895b9b2aa86bd204ecfdfce9e8387f3461fa3..f8a2e1ba9213013af7a3cb6b20057e458e267db3 100644 (file)
@@ -265,12 +265,6 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
                         disk->vdev, disk->pdev_path);
             return ERROR_INVAL;
         }
-        if (!S_ISBLK(a.stab.st_mode) &
-            !S_ISREG(a.stab.st_mode)) {
-            LOG(ERROR, "Disk vdev=%s phys path is not a block dev or file: %s",
-                       disk->vdev, disk->pdev_path);
-            return ERROR_INVAL;
-        }
     }
 
     if (disk->backend != LIBXL_DISK_BACKEND_UNKNOWN) {