sytnax-check: add a check for risky ctype macro use

* Makefile.maint (sc_risky_ctype_macros): New rule.

diff --git a/ChangeLog b/ChangeLog
index 7e576be89816c9e524790802889185436bf653fb..8453982a8283f796f42402c79be0f3b3fbad2770 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 Fri May  9 10:01:34 EST 2008 Jim Meyering <meyering@redhat.com>
 
+       sytnax-check: add a check for risky ctype macro use
+       * Makefile.maint (sc_risky_ctype_macros): New rule.
+
        avoid one more ctype vs. sign-extension problem
        * src/util.c (TOLOWER): Also convert tolower argument.
 

diff --git a/Makefile.maint b/Makefile.maint
index ddf42bc68937700dc267cc3d78609fe962932424..bab8e1d069b26ad15de7d9d02a0055f222c02c81 100644 (file)
--- a/Makefile.maint
+++ b/Makefile.maint
@@ -302,6 +302,15 @@ sc_TAB_in_indentation:
          { echo '$(ME): found TAB(s) use for indentation; use spaces'  \
                1>&2; exit 1; } || :
 
+ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
+|isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
+
+sc_risky_ctype_macros:
+       @grep -E '\b($(ctype_re)) *\(' /dev/null                        \
+            $$($(VC_LIST_EXCEPT)) | grep -v to_uchar &&                \
+         { echo '$(ME): found ctype macro use without to_uchar'        \
+               1>&2; exit 1; } || :
+
 # Match lines like the following, but where there is only one space
 # between the options and the description:
 #   -D, --all-repeated[=delimit-method]  print all duplicate lines\n