]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuBuildHostNetStr: remove dead code
authorJán Tomko <jtomko@redhat.com>
Fri, 14 Oct 2016 14:17:06 +0000 (16:17 +0200)
committerJán Tomko <jtomko@redhat.com>
Fri, 21 Oct 2016 14:01:10 +0000 (16:01 +0200)
This function is never called for VIR_DOMAIN_NET_TYPE_HOSTDEV,
and the dead code comment agrees.

Introduced by commit 1dcbef8a.

src/qemu/qemu_command.c

index 76c5bcb4f9b451d6185382bf4be3756c0576b40b..20a26ceaedafdcbba3325cc3448507d8c8e27142 100644 (file)
@@ -3723,11 +3723,6 @@ qemuBuildHostNetStr(virDomainNetDefPtr net,
         virBufferAsprintf(&buf, "user%c", type_sep);
         break;
 
-    case VIR_DOMAIN_NET_TYPE_HOSTDEV:
-        /* Should have been handled earlier via PCI/USB hotplug code. */
-        virObjectUnref(cfg);
-        return NULL;
-
     case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
         virBufferAsprintf(&buf, "vhost-user%cchardev=char%s,",
                           type_sep,
@@ -3737,6 +3732,8 @@ qemuBuildHostNetStr(virDomainNetDefPtr net,
                               net->driver.virtio.queues);
         break;
 
+    case VIR_DOMAIN_NET_TYPE_HOSTDEV:
+        /* Should have been handled earlier via PCI/USB hotplug code. */
     case VIR_DOMAIN_NET_TYPE_LAST:
         break;
     }