]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: don't shadow global umask declaration
authorMartin Kletzander <mkletzan@redhat.com>
Wed, 3 Sep 2014 13:39:15 +0000 (15:39 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 3 Sep 2014 13:39:15 +0000 (15:39 +0200)
Commit 0e1a1a8c introduced umask for virCommand, but the variables
used emit a warning on older compilers about shadowed global
declaration.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/util/vircommand.c

index efb5f69e01963f8b4aefd9bdd94bba5299a005e1..cbe94f8d3bff398531c87513b111976d2c8eab13 100644 (file)
@@ -133,7 +133,7 @@ struct _virCommand {
 #if defined(WITH_SECDRIVER_APPARMOR)
     char *appArmorProfile;
 #endif
-    int umask;
+    int mask;
 };
 
 /* See virCommandSetDryRun for description for this variable */
@@ -583,8 +583,8 @@ virExec(virCommandPtr cmd)
 
     /* child */
 
-    if (cmd->umask)
-        umask(cmd->umask);
+    if (cmd->mask)
+        umask(cmd->mask);
     ret = EXIT_CANCELED;
     openmax = sysconf(_SC_OPEN_MAX);
     if (openmax < 0) {
@@ -1085,12 +1085,12 @@ virCommandSetMaxFiles(virCommandPtr cmd, unsigned int files)
     cmd->maxFiles = files;
 }
 
-void virCommandSetUmask(virCommandPtr cmd, int umask)
+void virCommandSetUmask(virCommandPtr cmd, int mask)
 {
     if (!cmd || cmd->has_error)
         return;
 
-    cmd->umask = umask;
+    cmd->mask = mask;
 }
 
 /**