]> xenbits.xensource.com Git - libvirt.git/commitdiff
admin: rpc: virnetserver: Fix updating of the client limits
authorErik Skultety <eskultet@redhat.com>
Wed, 20 Jul 2016 10:10:29 +0000 (12:10 +0200)
committerErik Skultety <eskultet@redhat.com>
Tue, 2 Aug 2016 12:51:13 +0000 (14:51 +0200)
Commit 2737aaaf changed our policy for accepting new clients in a way, that
instead of accepting new clients only to disconnect them immediately, since
that would overcommit the limit, we temporarily disable polling for the
dedicated file descriptor, so any new connection will queue on the socket.
Commit 8b1f0469 then added the possibility to change the limits during runtime
but it didn't re-enable polling for the previously disabled file descriptor,
thus any new connection would still continue to queue on the socket. This patch
forces an update of the services each time the limits were changed in some way.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1357776

Signed-off-by: Erik Skultety <eskultet@redhat.com>
src/rpc/virnetserver.c

index c5caef3d703f4f6e84b6d8dee8d3bb408384737d..5b6bc4a555844376206cfb347fc31d87460b7c41 100644 (file)
@@ -1071,6 +1071,8 @@ virNetServerSetClientLimits(virNetServerPtr srv,
     if (maxClientsUnauth >= 0)
         srv->nclients_unauth_max = maxClientsUnauth;
 
+    virNetServerCheckLimits(srv);
+
     ret = 0;
  cleanup:
     virObjectUnlock(srv);