]> xenbits.xensource.com Git - people/royger/freebsd.git/commitdiff
Why use $? when you can use the command itself
authordteske <dteske@FreeBSD.org>
Tue, 13 Dec 2016 01:59:35 +0000 (01:59 +0000)
committerdteske <dteske@FreeBSD.org>
Tue, 13 Dec 2016 01:59:35 +0000 (01:59 +0000)
usr.sbin/bsdinstall/scripts/wlanconfig

index 32b83299ebf9eb28a96825dbe1a431320a7453c9..9c5422eafe0ebaf542ecddcc6f77ff664e3be55e 100755 (executable)
@@ -171,8 +171,7 @@ if ! wpa_cli ping > /dev/null 2>&1; then
                $DIALOG --backtitle "$DIALOG_BACKTITLE" --title "$msg_error" --msgbox \
                "Could not start wpa_supplicant!" 0 0; exit 1 || exit 1
 
-       wpa_cli ping > /dev/null 2>&1
-       if [ $? -ne 0 -a ! "$BSDINSTALL_CONFIGCURRENT" ]; then
+       if ! wpa_cli ping > /dev/null 2>&1 && [ ! "$BSDINSTALL_CONFIGCURRENT" ]; then
                $DIALOG \
                        --title "$msg_error" \
                        --backtitle "$DIALOG_BACKTITLE" \