]> xenbits.xensource.com Git - people/andrewcoop/xen-test-framework.git/commitdiff
Fix latent bug in 64bit exec_user_param()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 4 Apr 2018 20:18:34 +0000 (21:18 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 4 Apr 2018 20:18:34 +0000 (21:18 +0100)
Use a full %rsp reference rather than %esp.  Only a latent bug as the upper
bits will be clear.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
arch/x86/entry_64.S

index c638e601821e2b0311883564f1eaeb36cc27c2df..756ccb194365238fc77e6535ef7345a5a2d3732f 100644 (file)
@@ -124,9 +124,9 @@ ENTRY(exec_user_param)          /* ulong (*fn)(ulong), ulong p1 */
 
         /* Apply and/or masks to eflags. */
         mov exec_user_efl_and_mask(%rip), %rdx
-        and %rdx, (%esp)
+        and %rdx, (%rsp)
         mov exec_user_efl_or_mask(%rip), %rdx
-        or %rdx, (%esp)
+        or %rdx, (%rsp)
 
         push exec_user_cs(%rip) /* CS */
         push $exec_user_stub    /* RIP */