]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
vfio/pci: Disable INTx in vfio_realize error path
authorZhenzhong Duan <zhenzhong.duan@intel.com>
Mon, 3 Jul 2023 07:15:06 +0000 (15:15 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Sat, 5 Aug 2023 05:39:54 +0000 (08:39 +0300)
When vfio realize fails, INTx isn't disabled if it has been enabled.
This may confuse host side with unhandled interrupt report.

Fixes: c5478fea27ac ("vfio/pci: Respond to KVM irqchip change notifier")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
(cherry picked from commit adee0da0368f50b3ee934cdeeb6076466dabb268)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/vfio/pci.c

index 53dcb3efaa3f93e418b51fa649ee15343538c2e2..62013c672f1d3cced80756555783571cadc28337 100644 (file)
@@ -3160,6 +3160,9 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
     return;
 
 out_deregister:
+    if (vdev->interrupt == VFIO_INT_INTx) {
+        vfio_intx_disable(vdev);
+    }
     pci_device_set_intx_routing_notifier(&vdev->pdev, NULL);
     if (vdev->irqchip_change_notifier.notify) {
         kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier);