]> xenbits.xensource.com Git - people/julieng/linux-arm.git/commitdiff
spi: spreadtrum adi: add hwspinlock dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 5 Oct 2017 20:39:37 +0000 (22:39 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 5 Oct 2017 20:57:16 +0000 (21:57 +0100)
With CONFIG_HWSPINLOCK=m, the new driver fails to link as a built-in driver:

drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x18): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xfc): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x108): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x268): undefined reference to `hwspin_lock_free'

This adds a hard Kconfig dependency on HWSPINLOCK for the !COMPILE_TEST
case, and allows compile-testing with HWSPINLOCK completely disabled,
which will then rely on the existing stub API.

Fixes: 7e2903cb91df ("spi: Add ADI driver for Spreadtrum platform")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/Kconfig

index 0c38a5bfcd746bc2e003358f68acbd2af6745d4e..2c96f744352b2d6fb2144e6d7e0076df75b51d00 100644 (file)
@@ -629,6 +629,7 @@ config SPI_SIRF
 config SPI_SPRD_ADI
        tristate "Spreadtrum ADI controller"
        depends on ARCH_SPRD || COMPILE_TEST
+       depends on HWSPINLOCK || (COMPILE_TEST && !HWSPINLOCK)
        help
          ADI driver based on SPI for Spreadtrum SoCs.