]> xenbits.xensource.com Git - xen.git/commitdiff
x86emul: fix #XM delivery typo
authorJan Beulich <jbeulich@suse.com>
Thu, 22 Mar 2018 17:02:19 +0000 (18:02 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 22 Mar 2018 17:02:19 +0000 (18:02 +0100)
This clearly wasn't meant the way it was originally written.

Reported-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/x86_emulate/x86_emulate.c

index d97e262386a81c73e3c470236457c5842e89915a..3389050ab459dd8289c23be7a8c4d473e2c0bf21 100644 (file)
@@ -8662,7 +8662,7 @@ x86_emulate(
     {
         unsigned long cr4;
 
-        if ( !ops->read_cr || !ops->read_cr(4, &cr4, ctxt) == X86EMUL_OKAY )
+        if ( !ops->read_cr || ops->read_cr(4, &cr4, ctxt) != X86EMUL_OKAY )
             cr4 = X86_CR4_OSXMMEXCPT;
         generate_exception(cr4 & X86_CR4_OSXMMEXCPT ? EXC_XM : EXC_UD);
     }