]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
x86/build: Rework includes in genapic/probe.c
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 5 Sep 2024 20:40:20 +0000 (21:40 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 9 Sep 2024 13:59:05 +0000 (14:59 +0100)
probe.c includes a large number of headers which are unused, and not from
churn so far as I can see in history.  Strip back to a reasonable set.

One complication is that genapic.h has to include xen/cpumask.h because
there's no way to forward declare a cpumask_t.

Also strip trailing whitespace while adjusting the file.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/genapic/probe.c
xen/arch/x86/include/asm/genapic.h

index 10ceeae4d2473e2232a2b1226c366639c02d15d7..946c3d3ce36447ef76058a0f9b1aa749f78cc9c3 100644 (file)
@@ -1,25 +1,23 @@
-/* Copyright 2003 Andi Kleen, SuSE Labs. 
- * Subject to the GNU Public License, v.2 
- * 
+/* Copyright 2003 Andi Kleen, SuSE Labs.
+ * Subject to the GNU Public License, v.2
+ *
  * Generic x86 APIC driver probe layer.
- */  
-#include <xen/cpumask.h>
-#include <xen/string.h>
-#include <xen/kernel.h>
-#include <xen/ctype.h>
+ */
+#include <xen/bug.h>
+#include <xen/errno.h>
 #include <xen/init.h>
 #include <xen/param.h>
-#include <asm/cache.h>
-#include <asm/fixmap.h>
-#include <asm/mpspec.h>
-#include <asm/apicdef.h>
-#include <asm/mach-generic/mach_apic.h>
-#include <asm/setup.h>
+#include <xen/sections.h>
+#include <xen/string.h>
+#include <xen/types.h>
+
+#include <asm/apic.h>
+#include <asm/genapic.h>
 
 struct genapic __ro_after_init genapic;
 
 static const struct genapic *const __initconstrel apic_probe[] = {
-       &apic_bigsmp, 
+       &apic_bigsmp,
        &apic_default,  /* must be last */
        NULL,
 };
@@ -57,8 +55,8 @@ static int __init cf_check genapic_apic_force(const char *str)
 }
 custom_param("apic", genapic_apic_force);
 
-void __init generic_apic_probe(void) 
-{ 
+void __init generic_apic_probe(void)
+{
        int i;
 
        record_boot_APIC_mode();
@@ -75,4 +73,4 @@ void __init generic_apic_probe(void)
        BUG_ON(!genapic.name);
 
        printk(KERN_INFO "Using APIC driver %s\n", genapic.name);
-} 
+}
index 970df8ffe0a488aaa09cae3d5df16a6327317495..a694371c6d1623b6a96da5c24608ea472da0f0a9 100644 (file)
@@ -1,6 +1,8 @@
 #ifndef _ASM_GENAPIC_H
 #define _ASM_GENAPIC_H 1
 
+#include <xen/cpumask.h>
+
 /*
  * Generic APIC driver interface.
  *