]> xenbits.xensource.com Git - libvirt.git/commitdiff
admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew
authorErik Skultety <eskultet@redhat.com>
Sat, 14 May 2016 17:10:39 +0000 (19:10 +0200)
committerErik Skultety <eskultet@redhat.com>
Mon, 16 May 2016 14:26:47 +0000 (16:26 +0200)
When registering admin UNIX socket, a new service is created for it. This
service is incorrectly initialized to be readonly, which is later inherited by
all clients connected to the socket. In libvirt-admin's case there currently
isn't any use for the attribute anyway, but since the socket has root-only
access permissions, the least we can do is to make every admin client
connected to it report readonly as false.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
daemon/libvirtd.c

index cc5190f096975634623349a8f793e08f09016133..f24fb2200726aad640c2e1e3b3074f62ecdc42d7 100644 (file)
@@ -543,7 +543,7 @@ daemonSetupNetworking(virNetServerPtr srv,
 #if WITH_GNUTLS
                                                   NULL,
 #endif
-                                                  true,
+                                                  false,
                                                   config->admin_max_queued_clients,
                                                   config->admin_max_client_requests)))
             goto cleanup;