]> xenbits.xensource.com Git - libvirt.git/commitdiff
virJSONValueObjectAddVArgs: Use autofree for the temporary bitmap
authorPeter Krempa <pkrempa@redhat.com>
Fri, 12 Feb 2021 09:56:49 +0000 (10:56 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Sat, 20 Feb 2021 12:26:37 +0000 (13:26 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/util/virjson.c

index e4d71d3e0934176fb7a811c7e1a0f0b180b012b1..7b52525797c6c86a894df1c1213c1e7ed7cb25e9 100644 (file)
@@ -305,7 +305,7 @@ virJSONValueObjectAddVArgs(virJSONValuePtr obj,
         case 'M':
         case 'm': {
             virBitmapPtr map = va_arg(args, virBitmapPtr);
-            virJSONValuePtr jsonMap;
+            g_autoptr(virJSONValue) jsonMap = NULL;
 
             if (!map) {
                 if (type == 'M')
@@ -321,7 +321,8 @@ virJSONValueObjectAddVArgs(virJSONValuePtr obj,
                 return -1;
 
             if ((rc = virJSONValueObjectAppend(obj, key, jsonMap)) < 0)
-                virJSONValueFree(jsonMap);
+                return -1;
+            jsonMap = NULL;
         } break;
 
         default: