]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
netrom: Fix a data-race around sysctl_netrom_obsolescence_count_initialiser
authorJason Xing <kernelxing@tencent.com>
Mon, 4 Mar 2024 08:20:36 +0000 (16:20 +0800)
committerSasha Levin <sashal@kernel.org>
Fri, 15 Mar 2024 14:48:16 +0000 (10:48 -0400)
[ Upstream commit cfd9f4a740f772298308b2e6070d2c744fb5cf79 ]

We need to protect the reader reading the sysctl value
because the value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netrom/nr_route.c

index 6f709fdffc11fad0a9245cd1cab523378ea48219..b8ddd8048f352c4bad595b58d820d283b535f90b 100644 (file)
@@ -766,7 +766,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
        if (ax25 != NULL) {
                ret = nr_add_node(nr_src, "", &ax25->dest_addr, ax25->digipeat,
                                  ax25->ax25_dev->dev, 0,
-                                 sysctl_netrom_obsolescence_count_initialiser);
+                                 READ_ONCE(sysctl_netrom_obsolescence_count_initialiser));
                if (ret)
                        return ret;
        }