]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Alter error message for vHBA creation using parent wwnn/wwpn
authorJohn Ferlan <jferlan@redhat.com>
Wed, 15 Mar 2017 19:07:21 +0000 (15:07 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 16 Mar 2017 01:23:18 +0000 (21:23 -0400)
Commit id 'bb74a7ffe' added a fairly non specific message when providing
only the <parent wwnn='xxx'/> or <parent wwpn='xxx'/> instead of providing
both wwnn and wwpn. This patch just modifies the message to be more specific
about which was missing.

src/conf/node_device_conf.c

index ba727468e8b5430def2c14f89c9922e78a39b978..7d0baa9d1a7131e53a505045db1b54b53a7937df 100644 (file)
@@ -1615,10 +1615,19 @@ virNodeDeviceDefParseXML(xmlXPathContextPtr ctxt,
     def->parent = virXPathString("string(./parent[1])", ctxt);
     def->parent_wwnn = virXPathString("string(./parent[1]/@wwnn)", ctxt);
     def->parent_wwpn = virXPathString("string(./parent[1]/@wwpn)", ctxt);
-    if ((def->parent_wwnn && !def->parent_wwpn) ||
-        (!def->parent_wwnn && def->parent_wwpn)) {
-        virReportError(VIR_ERR_XML_ERROR, "%s",
-                       _("must supply both wwnn and wwpn for parent"));
+    if (def->parent_wwnn && !def->parent_wwpn) {
+        virReportError(VIR_ERR_XML_ERROR,
+                       _("when providing parent wwnn='%s', the "
+                         "wwpn must also be provided"),
+                       def->parent_wwnn);
+        goto error;
+    }
+
+    if (!def->parent_wwnn && def->parent_wwpn) {
+        virReportError(VIR_ERR_XML_ERROR,
+                       _("when providing parent wwpn='%s', the "
+                         "wwnn must also be provided"),
+                       def->parent_wwpn);
         goto error;
     }
     def->parent_fabric_wwn = virXPathString("string(./parent[1]/@fabric_wwn)",