]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: Fix updating balloon period in live XML
authorErik Skultety <eskultet@redhat.com>
Thu, 2 Oct 2014 12:48:02 +0000 (14:48 +0200)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 2 Oct 2014 20:10:53 +0000 (16:10 -0400)
Up until now, we set memballoon period in monitor successfully, however
we did not update domain definition structure, thus dumpxml was omitting
period attribute in memballoon element

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140960

src/qemu/qemu_driver.c

index 421faa23016bf338966e7f834b0a2b3acb7de6ec..7c0999871eb8cf0239277e995213f0d05b772c07 100644 (file)
@@ -2460,9 +2460,15 @@ static int qemuDomainSetMemoryStatsPeriod(virDomainPtr dom, int period,
         qemuDomainObjEnterMonitor(driver, vm);
         r = qemuMonitorSetMemoryStatsPeriod(priv->mon, period);
         qemuDomainObjExitMonitor(driver, vm);
-        if (r < 0)
+        if (r < 0) {
             virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                            _("unable to set balloon driver collection period"));
+            goto endjob;
+        }
+
+        vm->def->memballoon->period = period;
+        if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0)
+            goto endjob;
     }
 
     if (flags & VIR_DOMAIN_AFFECT_CONFIG) {