Implied by QEMU >= 1.2.0.
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
static void
virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps)
{
- virQEMUCapsSet(qemuCaps, QEMU_CAPS_SMBIOS_TYPE);
virQEMUCapsSet(qemuCaps, QEMU_CAPS_VGA_NONE);
virQEMUCapsSet(qemuCaps, QEMU_CAPS_DRIVE_AIO);
virQEMUCapsSet(qemuCaps, QEMU_CAPS_CHARDEV_SPICEVMC);
QEMU_CAPS_NESTING, /* -enable-nesting (SVM/VMX) */
X_QEMU_CAPS_NAME_PROCESS, /* Is -name process= available */
X_QEMU_CAPS_DRIVE_READONLY, /* -drive readonly=on|off */
- QEMU_CAPS_SMBIOS_TYPE, /* Is -smbios type= available */
+ X_QEMU_CAPS_SMBIOS_TYPE, /* Is -smbios type= available */
/* 45 */
X_QEMU_CAPS_VGA_QXL, /* The 'qxl' arg for '-vga' */
static int
qemuBuildSmbiosCommandLine(virCommandPtr cmd,
virQEMUDriverPtr driver,
- const virDomainDef *def,
- virQEMUCapsPtr qemuCaps)
+ const virDomainDef *def)
{
size_t i;
virSysinfoDefPtr source = NULL;
def->os.smbios_mode == VIR_DOMAIN_SMBIOS_EMULATE)
return 0;
- if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SMBIOS_TYPE)) {
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
- _("the QEMU binary %s does not support smbios settings"),
- def->emulator);
- return -1;
- }
-
/* should we really error out or just warn in those cases ? */
if (def->os.smbios_mode == VIR_DOMAIN_SMBIOS_HOST) {
if (driver->hostsysinfo == NULL) {
virUUIDFormat(def->uuid, uuid);
virCommandAddArgList(cmd, "-uuid", uuid, NULL);
- if (qemuBuildSmbiosCommandLine(cmd, driver, def, qemuCaps) < 0)
+ if (qemuBuildSmbiosCommandLine(cmd, driver, def) < 0)
goto error;
/*
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='enable-kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<flag name='kvm'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='hda-duplex'/>
<selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/>
- <flag name='smbios-type'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
<flag name='drive-aio'/>
<flag name='no-hpet'/>
<flag name='no-kvm-pit'/>
<flag name='pci-configfd'/>
- <flag name='smbios-type'/>
<flag name='spice'/>
<flag name='vga-none'/>
<flag name='boot-index'/>
DO_TEST_PARSE_ERROR("usb-controller-qemu-xhci-limit",
QEMU_CAPS_DEVICE_QEMU_XHCI);
- DO_TEST("smbios", QEMU_CAPS_SMBIOS_TYPE);
- DO_TEST_PARSE_ERROR("smbios-date", QEMU_CAPS_SMBIOS_TYPE);
- DO_TEST_PARSE_ERROR("smbios-uuid-match", QEMU_CAPS_SMBIOS_TYPE);
+ DO_TEST("smbios", NONE);
+ DO_TEST_PARSE_ERROR("smbios-date", NONE);
+ DO_TEST_PARSE_ERROR("smbios-uuid-match", NONE);
DO_TEST("watchdog", NONE);
DO_TEST("watchdog-device", NONE);