]> xenbits.xensource.com Git - libvirt.git/commitdiff
virresctrl: Sort resctrl array correctly in virResctrlMonitorGetStats()
authorHuaqiang <huaqiang.wang@intel.com>
Fri, 10 May 2019 15:21:47 +0000 (23:21 +0800)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 13 May 2019 12:38:58 +0000 (14:38 +0200)
The qsort element is a pointer of virResctrlMonitorStats, and
the comparing function's arguments have a type of pointer of
virResctrlMonitorStatsPtr.

Signed-off-by: Huaqiang <huaqiang.wang@intel.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/util/virresctrl.c

index b845f366f0fdecb046c2ce9ca47c12f7d9ae6854..90532cf1ccba50ed37f70db8fa3ad6751c2185e7 100644 (file)
@@ -2659,8 +2659,8 @@ static int
 virResctrlMonitorStatsSorter(const void *a,
                              const void *b)
 {
-    return ((virResctrlMonitorStatsPtr)a)->id
-        - ((virResctrlMonitorStatsPtr)b)->id;
+    return (*(virResctrlMonitorStatsPtr *)a)->id
+        - (*(virResctrlMonitorStatsPtr *)b)->id;
 }
 
 
@@ -2758,7 +2758,7 @@ virResctrlMonitorGetStats(virResctrlMonitorPtr monitor,
 
     /* Sort in id's ascending order */
     if (*nstats)
-        qsort(*stats, *nstats, sizeof(*stat), virResctrlMonitorStatsSorter);
+        qsort(*stats, *nstats, sizeof(**stats), virResctrlMonitorStatsSorter);
 
     ret = 0;
  cleanup: