]> xenbits.xensource.com Git - people/andrewcoop/xen.git/commitdiff
libxl: fix erroneous negation for isstubdom
authorSander Eikelenboom <linux@eikelenboom.it>
Sat, 10 Dec 2016 17:59:08 +0000 (18:59 +0100)
committerWei Liu <wei.liu2@citrix.com>
Mon, 12 Dec 2016 09:42:45 +0000 (09:42 +0000)
Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an erroneous
negation which gave the isstubdom bool the opposite semantics, causing
the subsequent code to take the wrong code path, which breaks HVM
pci-passthrough.

Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
Acked-by: Cedric Bosdonnat <cbosdonnat@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxl/libxl_pci.c

index 3b707f3691fedcee694323754ebbfbed592cf5df..83953527b855812db16a8431d5beb7c022eb4f5a 100644 (file)
@@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, i
     int irq, i, rc, hvm = 0;
     uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
     uint32_t domainid = domid;
-    bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
+    bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
 
     if (type == LIBXL_DOMAIN_TYPE_INVALID)
         return ERROR_FAIL;