]> xenbits.xensource.com Git - qemu-xen-4.5-testing.git/commitdiff
piix4acpi, xen: Clarify that the qemu_set_irq calls just do an IRQ pulse.
authorKonrad Rzeszutek Wilk <konrad@kernel.org>
Tue, 14 May 2013 17:48:48 +0000 (18:48 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 21 May 2013 10:49:14 +0000 (11:49 +0100)
The "qemu_cpu_notify" raises and lowers the ACPI SCI line when the
vCPU state has changed.

Instead of doing the two functions, just use one function that
describes exactly what it does.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com> (for 4.3 release)
hw/piix4acpi.c

index 54d566bb0b73d91488aa85c068a50b19f9cfeb31..bf916d9560b085ae95da0b35e61ff69dd38f14e0 100644 (file)
@@ -834,8 +834,6 @@ int qemu_cpu_add_remove(int cpu, int state)
 }
 void qemu_cpu_notify(void)
 {
-    if (gpe_state.gpe0_en[0] & 4) {
-        qemu_set_irq(sci_irq, 1);
-        qemu_set_irq(sci_irq, 0);
-    }
+    if (gpe_state.gpe0_en[0] & 4)
+        qemu_irq_pulse(sci_irq);
 }