]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
pci: Reject pcie_aer_inject_error -c with symbolic error status
authorMarkus Armbruster <armbru@redhat.com>
Thu, 1 Dec 2022 12:11:33 +0000 (13:11 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 19 Dec 2022 15:21:56 +0000 (16:21 +0100)
When argument @error_status is symbolic, flag -c is ignored.  Reject
it instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221201121133.3813857-14-armbru@redhat.com>

hw/pci/pci-hmp-cmds.c

index a292d06ea080054d823fd37e19a27024ff4135af..fb7591d6ab9f0ff861c244eae2922a46737e334e 100644 (file)
@@ -189,6 +189,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict)
         }
         error_status = num;
         correctable = qdict_get_try_bool(qdict, "correctable", false);
+    } else {
+        if (qdict_haskey(qdict, "correctable")) {
+            error_setg(&err, "-c is only valid with numeric error status");
+            goto out;
+        }
     }
     aer_err.status = error_status;
     aer_err.source_id = pci_requester_id(dev);