]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
tools/xl: fix channel configuration setting
authorJuergen Gross <jgross@suse.com>
Wed, 5 Mar 2025 15:37:37 +0000 (16:37 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 5 Mar 2025 15:37:37 +0000 (16:37 +0100)
Channels work differently than other device types: their devid should
be -1 initially in order to distinguish them from the primary console
which has the devid of 0.

So when parsing the channel configuration, use
ARRAY_EXTEND_INIT_NODEVID() in order to avoid overwriting the devid
set by libxl_device_channel_init().

Fixes: 3a6679634766 ("libxl: set channel devid when not provided by application")
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
tools/xl/xl_parse.c

index 3d85be7dd4fd9f813cb6310b5dad6b879dc10e6b..089a88935aff3ab6c98f47a70050eb9db772f546 100644 (file)
@@ -2423,8 +2423,9 @@ void parse_config_data(const char *config_source,
             char *path = NULL;
             int len;
 
-            chn = ARRAY_EXTEND_INIT(d_config->channels, d_config->num_channels,
-                                   libxl_device_channel_init);
+            chn = ARRAY_EXTEND_INIT_NODEVID(d_config->channels,
+                                            d_config->num_channels,
+                                            libxl_device_channel_init);
 
             split_string_into_string_list(buf, ",", &pairs);
             len = libxl_string_list_length(&pairs);