]> xenbits.xensource.com Git - libvirt.git/commitdiff
cpu_map: No longer ignore vmx- features in sync_qemu_features_i386.py
authorTim Wiederhake <twiederh@redhat.com>
Thu, 9 Nov 2023 12:19:41 +0000 (13:19 +0100)
committerTim Wiederhake <twiederh@redhat.com>
Fri, 24 Nov 2023 09:46:32 +0000 (10:46 +0100)
Some guest OSes require cpu features from the vmx-* family,
e.g. vmx-xsaves. Up to now, libvirt ignored these features as they
were not required yet. qemu does not automatically enable e.g.
"vmx-xsaves" when requesting "xsaves":

    qmp="qemu-kvm -machine accel=kvm -nodefaults -nographic -qmp stdio"
    $(qmp) <<-EOF | jq | grep "xsaves"
    { "execute": "qmp_capabilities" }
    {
      "execute": "query-cpu-model-expansion",
      "arguments": {
        "type": "full",
        "model": {
          "name": "Skylake-Client-v1",
          "props": { "xsaves": true }   `# set to "true" or "false"`
        }
      }
    }
    { "execute": "quit" }
    EOF

with xsaves "false":
    "xsaves": false,
    "vmx-xsaves": false,

with xsaves "true":
    "xsaves": true,
    "vmx-xsaves": false,

Stop ignoring vmx-* features and begin adding them to libvirt's
database.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/cpu_map/sync_qemu_features_i386.py

index 9e77d44baeae7362dea3dc5c927b16b592501e64..dcd58cd5905d7ddb6b401721e2b187ed827ee38a 100755 (executable)
@@ -99,7 +99,7 @@ def ignore_feature(feature):
 
     name = feature["name"]
 
-    if name.startswith("x-") or name.startswith("vmx-"):
+    if name.startswith("x-"):
         return True
 
     if name in ignored_features: