]> xenbits.xensource.com Git - people/dstodden/blktap.git/commitdiff
CA-26523: Void tapdisk_daemon_check_fds().
authorDaniel Stodden <daniel.stodden@citrix.com>
Mon, 6 Apr 2009 20:22:21 +0000 (13:22 -0700)
committerDaniel Stodden <daniel.stodden@citrix.com>
Mon, 6 Apr 2009 20:22:21 +0000 (13:22 -0700)
Failures go unused either way. Would not disrupt overall event
dispatch for any individual failure.

daemon/tapdisk-daemon.c

index ddf222a0d86fbb2997498eb6c4ba765b08da4b7d..6e033cb7953c8e54bfc302b5853c64928b148fb7 100644 (file)
@@ -466,7 +466,7 @@ tapdisk_daemon_set_fds(fd_set *readfds)
        return max;
 }
 
-static int
+static void
 tapdisk_daemon_check_fds(fd_set *readfds)
 {
        int err;
@@ -476,10 +476,10 @@ tapdisk_daemon_check_fds(fd_set *readfds)
                xs_fire_next_watch(tapdisk_daemon.xsh);
 
        tapdisk_daemon_for_each_channel(channel, tmp)
-               if (FD_ISSET(channel->read_fd, readfds))
-                       return tapdisk_daemon_receive_message(channel->read_fd);
-
-       return 0;
+               if (FD_ISSET(channel->read_fd, readfds)) {
+                       tapdisk_daemon_receive_message(channel->read_fd);
+                       return;
+               }
 }
 
 static int
@@ -495,10 +495,10 @@ tapdisk_daemon_run(void)
                if (err < 0)
                        continue;
 
-               err = tapdisk_daemon_check_fds(&readfds);
+               tapdisk_daemon_check_fds(&readfds);
        }
 
-       return err;
+       return 0;
 }
 
 void