]> xenbits.xensource.com Git - people/aperard/osstest.git/commitdiff
ts-examine-logs-save: Do not do readdir $! check
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 23 May 2017 18:06:42 +0000 (19:06 +0100)
committerIan Jackson <ian.jackson@eu.citrix.com>
Thu, 1 Jun 2017 10:26:49 +0000 (11:26 +0100)
In perl 5.14 in Massachusetts, this produces this message
  /home/logs/logs/109694/test-amd64-amd64-examine Bad file descriptor at ./ts-examine-logs-save line 100.

Sadly this means there is no way to tell failure apart from end of
directory.  This patch should be reverted when we have a fixed version
of perl.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
ts-examine-logs-save

index 014522a77a00aba543db369bf80b317304f23f11..b9c9941cf5ab9c0badc412d48a60623f0ae08d33 100755 (executable)
@@ -97,7 +97,7 @@ sub save_logs () {
        logm("saving $f");
        link "$stash/$f", "$td/$f" or die "$stash $td $f $!";
     }
-    die "$stash $!" if $!;
+    die "$stash $!" if $!;
     closedir D;
 }