]> xenbits.xensource.com Git - libvirt.git/commitdiff
virnetdevip: Free data.devices in virNetDevIPCheckIPv6Forwarding() too
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 13 Aug 2018 09:16:06 +0000 (11:16 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 13 Aug 2018 10:32:02 +0000 (12:32 +0200)
We are freeing the individual strings (which were filled by
virNetDevIPCheckIPv6ForwardingCallback()) but not the array
itself.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/util/virnetdevip.c

index c6d61756273443b7570d3992ebf2ef33b3e5cc2e..866ddcc213b1f5f523ee45ed786aaaf319b1f0c4 100644 (file)
@@ -651,8 +651,7 @@ virNetDevIPCheckIPv6Forwarding(void)
 
  cleanup:
     nlmsg_free(nlmsg);
-    for (i = 0; i < data.ndevices; i++)
-        VIR_FREE(data.devices[i]);
+    virStringListFreeCount(data.devices, data.ndevices);
     return valid;
 }