]> xenbits.xensource.com Git - libvirt.git/commitdiff
libvirtd: avoid memory leak on OOM
authorEric Blake <eblake@redhat.com>
Thu, 30 Jun 2011 23:08:41 +0000 (17:08 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 1 Jul 2011 22:46:20 +0000 (16:46 -0600)
Detected by Coverity; only strikes on OOM so not serious.

* daemon/libvirtd.c (daemonPidFilePath): Plug leak.

daemon/libvirtd.c

index 60ee705cef6a7931f1bb4814355d5873e6fc6602..06d2077bd403b50c7fb7fb4c136fdf157252519f 100644 (file)
@@ -310,8 +310,10 @@ daemonPidFilePath(bool privileged,
         if (!(userdir = virGetUserDirectory(geteuid())))
             goto error;
 
-        if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0)
+        if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) {
+            VIR_FREE(userdir);
             goto no_memory;
+        }
 
         VIR_FREE(userdir);
     }