]> xenbits.xensource.com Git - xen.git/commitdiff
tools/libxc: Do not crash freeing logger on xc_interface_open error path
authorIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 28 Jun 2010 15:56:52 +0000 (16:56 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 28 Jun 2010 15:56:52 +0000 (16:56 +0100)
libxc could sometimes free the logger which xl created.
Thanks to report from Yang Hongyang <yanghy@cn.fujitsu.com>.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxc/xc_private.c

index 9761b98af4b1db0152bab2658f522cf073d043ee..befc3f965a4c0c7f0bb7d98c0b43f5dfa7f8f018 100644 (file)
@@ -52,7 +52,7 @@ xc_interface *xc_interface_open(xentoollog_logger *logger,
     return xch;
 
  err:
-    if (xch) xtl_logger_destroy(xch->error_handler);
+    if (xch) xtl_logger_destroy(xch->error_handler_tofree);
     if (xch != &xch_buf) free(xch);
     return 0;
 }