]> xenbits.xensource.com Git - xen.git/commitdiff
libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain
authorWei Liu <wei.liu2@citrix.com>
Fri, 17 Jul 2015 17:01:08 +0000 (18:01 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Tue, 21 Jul 2015 14:14:06 +0000 (15:14 +0100)
Call libxl_cpupoolinfo_init at the beginning.  Change two returns to
goto out so that libxl_cpupoolinfo_dispose is called in failure path.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_dom.c

index 601d5cc7c19a46cc66189c571b062fb2ca284cd6..edd7f3f772e13bec58d7f54282ece8f59df0283e 100644 (file)
@@ -142,6 +142,7 @@ static int numa_place_domain(libxl__gc *gc, uint32_t domid,
 
     libxl__numa_candidate_init(&candidate);
     libxl_bitmap_init(&cpupool_nodemap);
+    libxl_cpupoolinfo_init(&cpupool_info);
 
     /*
      * Extract the cpumap from the cpupool the domain belong to. In fact,
@@ -150,10 +151,10 @@ static int numa_place_domain(libxl__gc *gc, uint32_t domid,
      */
     rc = cpupool = libxl__domain_cpupool(gc, domid);
     if (rc < 0)
-        return rc;
+        goto out;
     rc = libxl_cpupool_info(CTX, &cpupool_info, cpupool);
     if (rc)
-        return rc;
+        goto out;
 
     rc = libxl_domain_need_memory(CTX, info, &memkb);
     if (rc)