build: drop the getopt-posix gnulib module

The getopt-posix module fixes a problem with optind being incorrectly
set after a failed option parse. It was also previously used to allow
the bhyve driver to access a private internal reentrant getopt impl.
None of this matters to libvirt code any more.

This partially reverts

  commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
  Author: Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Date:   Thu Jun 9 00:50:35 2016 +0000

    gnulib: add getopt module

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

diff --git a/bootstrap.conf b/bootstrap.conf
index 4f944a9c23782086b765f42d093259330baea496..22f6153f3c6d2137314b9da13253f8c2c5277e28 100644 (file)
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -51,7 +51,6 @@ fsync
 getaddrinfo
 getcwd-lgpl
 gethostname
-getopt-posix
 getpass
 getpeername
 getsockname

diff --git a/m4/virt-driver-bhyve.m4 b/m4/virt-driver-bhyve.m4
index f89a5f841acff4cb86d78b96ece4107ccdea2bd9..14b30c0b3e70281d2f73f335c3004788f6622323 100644 (file)
--- a/m4/virt-driver-bhyve.m4
+++ b/m4/virt-driver-bhyve.m4
@@ -51,9 +51,6 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_BHYVE],[
     AM_CONDITIONAL([WITH_BHYVE], [test "$with_bhyve" = "yes"])
 ])
 
-dnl Build with gnulib's getopt which contains a reentrant interface
-AC_DEFUN([gl_REPLACE_GETOPT_ALWAYS], [])
-
 AC_DEFUN([LIBVIRT_DRIVER_RESULT_BHYVE],[
     LIBVIRT_RESULT([Bhyve], [$with_bhyve])
 ])

diff --git a/po/POTFILES b/po/POTFILES
index 35fc26c4b91383cf8d5828b673096adf89fdc61b..9385fc4e158fc64868159f9f5580aa356927fb08 100644 (file)
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -1,5 +1,4 @@
 gnulib/lib/gai_strerror.c
-gnulib/lib/getopt.c
 gnulib/lib/regcomp.c
 src/access/viraccessdriverpolkit.c
 src/access/viraccessmanager.c