]> xenbits.xensource.com Git - people/dariof/qemu-xen.git/commitdiff
target/mips: Fix ADD.S FPU instruction
authorAlex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Fri, 3 Jul 2020 16:15:15 +0000 (17:15 +0100)
committerPhilippe Mathieu-Daudé <f4bug@amsat.org>
Tue, 14 Jul 2020 19:49:33 +0000 (21:49 +0200)
After merging latest QEMU upstream into our CHERI fork,
I noticed that some of the FPU tests in our MIPS baremetal
testsuite [*] started failing.
It turns out commit 1ace099f2a accidentally changed add.s
into a subtract.

[*] https://github.com/CTSRD-CHERI/cheritest

Fixes: 1ace099f2a ("target/mips: fpu: Demacro ADD.<D|S|PS>")
Signed-off-by: Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200703161515.25966-1-Alexander.Richardson@cl.cam.ac.uk>
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
target/mips/fpu_helper.c

index 7a3a61cab37ac27dd6f3e73e6dfd192202e03a36..56beda49d82d372a6f43cf7569c4528a52928b98 100644 (file)
@@ -1221,7 +1221,7 @@ uint32_t helper_float_add_s(CPUMIPSState *env,
 {
     uint32_t wt2;
 
-    wt2 = float32_sub(fst0, fst1, &env->active_fpu.fp_status);
+    wt2 = float32_add(fst0, fst1, &env->active_fpu.fp_status);
     update_fcr31(env, GETPC());
     return wt2;
 }