]> xenbits.xensource.com Git - people/vhanquez/xen-unstable.git/commitdiff
stubdom: Fix stubdom-dm using "grep" improperly
authorJohn Weekes <lists.xen@nuclearfallout.net>
Tue, 11 Jan 2011 16:42:41 +0000 (16:42 +0000)
committerJohn Weekes <lists.xen@nuclearfallout.net>
Tue, 11 Jan 2011 16:42:41 +0000 (16:42 +0000)
stubdom-dm uses "grep" on "xm list" output to determine whether it is
already running. The existing behavior is to use "grep $domname-dm" but
this will result in a false-positive in the case of another domU running
whose name ends with the full new name; for instance, if "abctest-dm" is
running, a new "test-dm" will spin forever, waiting for it the end.

Any easy fix is to have it use "grep -w" instead of "grep", searching
for the whole word only.

It also might be worth considering a switch to "xl list" from "xm list",
here and in other places.

Signed-off-by: John Weekes <lists.xen@nuclearfallout.net>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
stubdom/stubdom-dm

index c85fa536356f49191f2bf907c8a620a7b32260c9..05d07ac0d1066ccf5fa499a212c2c6eb59b9b368 100644 (file)
@@ -91,7 +91,7 @@ trap term SIGHUP
 ############
 # stubdomain
 # Wait for any previous stubdom to terminate
-while xm list | grep $domname-dm
+while xm list | grep -w $domname-dm
 do
        sleep 1
 done