virDomainMemballoonDef: Change type of model to virDomainMemballoonModel

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 20a60cff6ca43002c0221741de552da11420f60d..40930eed3967ca103f6b8f546f967854b5b5418c 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13532,6 +13532,7 @@ virDomainMemballoonDefParseXML(virDomainXMLOption *xmlopt,
     g_autofree char *model = NULL;
     g_autofree char *freepage_reporting = NULL;
     g_autofree char *deflate = NULL;
+    int model_value;
 
     def = g_new0(virDomainMemballoonDef, 1);
 
@@ -13542,11 +13543,12 @@ virDomainMemballoonDefParseXML(virDomainXMLOption *xmlopt,
         goto error;
     }
 
-    if ((def->model = virDomainMemballoonModelTypeFromString(model)) < 0) {
+    if ((model_value = virDomainMemballoonModelTypeFromString(model)) < 0) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("unknown memory balloon model '%s'"), model);
         goto error;
     }
+    def->model = model_value;
 
     if ((deflate = virXMLPropString(node, "autodeflate"))) {
         int value;

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index be8f43a35c99e6c41c201fb2536667f72aeb6308..760f0574affde07085e4da587cfdf7c964176931 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1924,7 +1924,7 @@ typedef enum {
 } virDomainMemballoonModel;
 
 struct _virDomainMemballoonDef {
-    int model;
+    virDomainMemballoonModel model;
     virDomainDeviceInfo info;
     int period; /* seconds between collections */
     virTristateSwitch autodeflate;

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 3ccb00ec3530c1b0c607141761487ba215679538..4de2158bea45f448840abd6f470e895d1e85f717 100644 (file)
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -740,9 +740,7 @@ libxlMakeDomBuildInfo(virDomainDef *def,
 
     /* only the 'xen' balloon device model is supported */
     if (def->memballoon) {
-        int model = def->memballoon->model;
-
-        switch ((virDomainMemballoonModel)model) {
+        switch (def->memballoon->model) {
         case VIR_DOMAIN_MEMBALLOON_MODEL_XEN:
             break;
         case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO:
@@ -750,7 +748,7 @@ libxlMakeDomBuildInfo(virDomainDef *def,
         case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO_NON_TRANSITIONAL:
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("unsupported balloon device model '%s'"),
-                           virDomainMemballoonModelTypeToString(model));
+                           virDomainMemballoonModelTypeToString(def->memballoon->model));
             return -1;
         case VIR_DOMAIN_MEMBALLOON_MODEL_NONE:
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
@@ -759,7 +757,7 @@ libxlMakeDomBuildInfo(virDomainDef *def,
             return -1;
         case VIR_DOMAIN_MEMBALLOON_MODEL_LAST:
         default:
-            virReportEnumRangeError(virDomainMemballoonModel, model);
+            virReportEnumRangeError(virDomainMemballoonModel, def->memballoon->model);
             return -1;
         }
     }

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index b564748d13d52a8d5c77ab51949154d729056955..a11e40d9b2e1a182295347f3f6c3b48d90a45ef0 100644 (file)
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -882,7 +882,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev,
     }
 
     case VIR_DOMAIN_DEVICE_MEMBALLOON:
-        switch ((virDomainMemballoonModel) dev->data.memballoon->model) {
+        switch (dev->data.memballoon->model) {
         case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO_TRANSITIONAL:
             /* Transitional devices only work in conventional PCI slots */
             return pciFlags;

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 3a7f231ce02108d2a9c6ac342a8f9e799d3f35f3..1e6f892e0814d6d2775a9f3b14f0b7f47c03ea05 100644 (file)
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -1030,7 +1030,7 @@ qemuMonitorInitBalloonObjectPath(qemuMonitor *mon,
 
     switch (balloon->info.type) {
     case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI:
-        switch ((virDomainMemballoonModel) balloon->model) {
+        switch (balloon->model) {
             case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO:
                 name = "virtio-balloon-pci";
                 break;