]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Remove bogus unref in virDBusMessageRead
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 19 Mar 2014 10:55:13 +0000 (10:55 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 21 Mar 2014 11:26:34 +0000 (11:26 +0000)
The virDBusMessageRead method should not have side-effects on
the message parameter passed in, so unref'ing it is wrong.
The caller should unref only when they decided they are done
with it.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/util/virdbus.c

index ecfe9f636418c1c99a040e1939166bb229e46f79..cbaf995813850f8f88fba66a2cda79dce0871318 100644 (file)
@@ -1421,7 +1421,6 @@ int virDBusMessageRead(DBusMessage *msg,
     ret = virDBusMessageDecodeArgs(msg, types, args);
     va_end(args);
 
-    dbus_message_unref(msg);
     return ret;
 }