networkValidate: Forbid new-line char in network name

New line character in name of network is now forbidden because it
mess virsh output and can be confusing for users.  Validation of
name is done in network driver, after parsing XML to avoid
problems with disappeared network which was already created with
new-line char in name.

Closes-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index b2af482725416d84e9881feae9ae65b16b1b56ab..9d7fc31f8f739bec024fe44d578ca561a02efd30 100644 (file)
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -2973,6 +2973,9 @@ networkValidate(virNetworkDriverStatePtr driver,
     bool bandwidthAllowed = true;
     bool usesInterface = false, usesAddress = false;
 
+    if (virXMLCheckIllegalChars("name", def->name, "\n") < 0)
+        return -1;
+
     /* Only the three L3 network types that are configured by libvirt
      * need to have a bridge device name / mac address provided
      */