Assume all the short args have optional args so allocate space for the

':'. It's slightly wasteful, but much easier (and the savings in bytes
at runtime would be tiny, but the code to do it larger).

Submitted by: Sebastian Huber

diff --git a/sbin/nvmecontrol/comnd.c b/sbin/nvmecontrol/comnd.c
index d8d97ad11b5be0d5f61bcf5f993557ea24c354dd..4233384eb1e3b1789b6523350579301fcab989c9 100644 (file)
--- a/sbin/nvmecontrol/comnd.c
+++ b/sbin/nvmecontrol/comnd.c
@@ -189,7 +189,7 @@ arg_parse(int argc, char * const * argv, const struct cmd *f)
        lopts = malloc((n + 2) * sizeof(struct option));
        if (lopts == NULL)
                err(1, "option memory");
-       p = shortopts = malloc((n + 3) * sizeof(char));
+       p = shortopts = malloc((2 * n + 3) * sizeof(char));
        if (shortopts == NULL)
                err(1, "shortopts memory");
        idx = 0;